i1909 - attempting debug log rest api requests #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushti
reviewed
Nov 28, 2022
| @@ -60,6 +60,7 @@ libraryDependencies ++= Seq( | |||
| "com.typesafe.akka" %% "akka-http" % akkaHttpVersion, | |||
| "com.typesafe.akka" %% "akka-parsing" % akkaHttpVersion, | |||
| "com.typesafe.akka" %% "akka-stream" % akkaVersion, | |||
| "com.typesafe.akka" %% "akka-slf4j" % akkaVersion, | |||
There was a problem hiding this comment.
Is the new dependency needed for purposes of this PR ?
There was a problem hiding this comment.
Yeah, this requires akka.event.slf4j.Slf4jLogger, the akka.event.LoggingAdapter does not log anything without it.
There was a problem hiding this comment.
And the configuration section I added should be always present when we are using SLF4J
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1909 ... Just note that there is a regression related to DEBUG logging #1676 (comment)
@kushti Is this OK ? Posting Bodies could just needlessly eat up disk space